feat(ingestion): implement hybrid metadata verification form #34 #41

Merged

mjasin merged 2 commits from feature/issue-34 into develop 2026-05-12 18:19:07 +00:00

Conversation 2 Commits 2 Files Changed 15

+533 -24

Antigravity commented 2026-05-12 12:55:50 +00:00

Collaborator

Copy Link

Copy Source

Description

This PR implements Issue #34: [UI/UX] Implement Hybrid Metadata Verification Form in Ingestion Modal.

Key Changes

• Metadata Verification State: Introduced a new state in BookIngestionModal.razor allowing users to edit Title and Author before final ingestion.
• Cover Image Preview: Added a high-fidelity cover preview with a CSS-based glowing placeholder fallback for books without embedded covers.
• Ingestion Pipeline:
  • Implemented IngestEbookCommand and IngestEbookCommandHandler.
  • Added IBookStorageService and its implementation for managing EPUB and cover file storage.
  • Exposed POST /api/library/ingest Minimal API endpoint with .DisableAntiforgery() to handle client-side JSON uploads.
• Stability Fixes:
  • Resolved DI validation errors in the WASM client by providing a dummy IBookStorageService registration.
  • Adjusted Kestrel request limits to handle large EPUB payloads (up to 100MB).
  • Corrected middleware ordering to ensure Antiforgery works correctly with Authentication.

Verification

• Solution builds successfully.
• Manual verification of modal state transitions and API ingestion logic.

Closes #34.

### Description This PR implements **Issue #34: [UI/UX] Implement Hybrid Metadata Verification Form in Ingestion Modal**. ### Key Changes - **Metadata Verification State**: Introduced a new state in `BookIngestionModal.razor` allowing users to edit `Title` and `Author` before final ingestion. - **Cover Image Preview**: Added a high-fidelity cover preview with a CSS-based glowing placeholder fallback for books without embedded covers. - **Ingestion Pipeline**: - Implemented `IngestEbookCommand` and `IngestEbookCommandHandler`. - Added `IBookStorageService` and its implementation for managing EPUB and cover file storage. - Exposed `POST /api/library/ingest` Minimal API endpoint with `.DisableAntiforgery()` to handle client-side JSON uploads. - **Stability Fixes**: - Resolved DI validation errors in the WASM client by providing a dummy `IBookStorageService` registration. - Adjusted Kestrel request limits to handle large EPUB payloads (up to 100MB). - Corrected middleware ordering to ensure Antiforgery works correctly with Authentication. ### Verification - Solution builds successfully. - Manual verification of modal state transitions and API ingestion logic. Closes #34.

Antigravity added 1 commit 2026-05-12 12:55:50 +00:00

feat(ingestion): implement hybrid metadata verification form in ingestion modal #34 94fd7cf5c1

mjasin approved these changes 2026-05-12 12:58:44 +00:00

Antigravity reviewed 2026-05-12 17:59:45 +00:00

Antigravity left a comment

Author

Collaborator

Copy Link

Copy Source

Automated review – please address the inline comments.

Automated review – please address the inline comments.

src/NexusReader.Application/Abstractions/Services/IBookStorageService.cs

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Consider adding XML documentation for SaveCoverAsync to clarify that a null return indicates no cover image.

Consider adding XML documentation for `SaveCoverAsync` to clarify that a `null` return indicates no cover image.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Adding an overload that accepts a Stream could improve memory usage for large files.

Adding an overload that accepts a Stream could improve memory usage for large files.

src/NexusReader.Application/Commands/Library/IngestEbookCommand.cs

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Document why the default TenantId is "global" and how multi‑tenant usage should override it.

Document why the default `TenantId` is "global" and how multi‑tenant usage should override it.

src/NexusReader.Application/Commands/Library/IngestEbookCommandHandler.cs

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Returned epubPath is a relative URL – confirm that Ebook.FilePath expects this format.

Returned `epubPath` is a relative URL – confirm that `Ebook.FilePath` expects this format.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Replace ToLower() comparison with String.Equals(..., StringComparison.OrdinalIgnoreCase) for case‑insensitive author lookup.

Replace `ToLower()` comparison with `String.Equals(..., StringComparison.OrdinalIgnoreCase)` for case‑insensitive author lookup.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

EF Core will assign the Author Id after SaveChangesAsync; the comment about needing to save can be removed.

EF Core will assign the Author Id after `SaveChangesAsync`; the comment about needing to save can be removed.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Consider wrapping only expected failure points in the catch block to avoid swallowing programming errors.

Consider wrapping only expected failure points in the catch block to avoid swallowing programming errors.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Include the original exception message in the error result for easier debugging.

Include the original exception message in the error result for easier debugging.

src/NexusReader.Application/Queries/Reader/LocalEpubMetadata.cs

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Mutable record is fine for binding; add XML docs for each property to improve IDE help.

Mutable record is fine for binding; add XML docs for each property to improve IDE help.

src/NexusReader.Infrastructure/DependencyInjection.cs

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

IBookStorageService is registered as Scoped. Since it only depends on IWebHostEnvironment, consider registering it as Singleton.

`IBookStorageService` is registered as Scoped. Since it only depends on `IWebHostEnvironment`, consider registering it as Singleton.

src/NexusReader.Infrastructure/Services/BookStorageService.cs

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Directory creation is lazy – ensure these folders are intended to be publicly served via wwwroot.

Directory creation is lazy – ensure these folders are intended to be publicly served via wwwroot.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Method returns a relative path. Document that callers should treat this as a URL path.

Method returns a relative path. Document that callers should treat this as a URL path.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Consider streaming the write operation for large files instead of loading the entire byte array.

Consider streaming the write operation for large files instead of loading the entire byte array.

src/NexusReader.UI.Shared/Components/Organisms/BookIngestionModal.razor

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Added additional services – confirm they are registered in DI.

Added additional services – confirm they are registered in DI.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

verification-state visibility logic looks correct.

`verification-state` visibility logic looks correct.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Placeholder SVG uses hard‑coded colors; consider using CSS variables for theme consistency.

Placeholder SVG uses hard‑coded colors; consider using CSS variables for theme consistency.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

IsIngesting flag correctly disables the Save button and shows loading state.

`IsIngesting` flag correctly disables the Save button and shows loading state.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

SaveToLibrary creates IngestEbookRequest – ensure the server side endpoint matches this contract.

`SaveToLibrary` creates `IngestEbookRequest` – ensure the server side endpoint matches this contract.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

After successful ingestion, consider navigating to the new book (uncomment navigation call).

After successful ingestion, consider navigating to the new book (uncomment navigation call).

src/NexusReader.Web.Client/Program.cs

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

ThrowingBookStorageService ensures DI validation; include a clear exception message.

`ThrowingBookStorageService` ensures DI validation; include a clear exception message.

src/NexusReader.Web/Program.cs

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

HttpClient configuration now falls back to NavigationManager.BaseUri – good for local dev.

HttpClient configuration now falls back to NavigationManager.BaseUri – good for local dev.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

UseAntiforgery() appears twice; remove the duplicate call.

`UseAntiforgery()` appears twice; remove the duplicate call.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Missing using System.Security.Claims; – add it to compile.

Missing `using System.Security.Claims;` – add it to compile.

Antigravity commented 2026-05-12 17:59:45 +00:00

Author

Collaborator

Copy Link

Copy Source

Endpoint api/library/ingest correctly disables antiforgery and requires auth.

Endpoint `api/library/ingest` correctly disables antiforgery and requires auth.

mjasin added 1 commit 2026-05-12 18:12:15 +00:00

refactor: address PR review comments for ingestion workflow 531ad3c2d0

mjasin merged commit d5c2952bec into develop 2026-05-12 18:19:07 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

mjasin

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Antigravity M.Wojtaszek mjasin (Marek Jaisński)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mjasin/Nexus.Reader#41