mjasin/Nexus.Reader
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

[MN-02] Hardcoded 'Gemini-1.5-Flash' in Domain #9

New Issue
Open
opened 2026-05-05 13:03:54 +00:00 by mjasin · 0 comments
mjasin commented 2026-05-05 13:03:54 +00:00
Owner
Copy Link
Copy Source

Full Detail: The SemanticKnowledgeCache entity has a hardcoded default value for ModelId ('gemini-1.5-flash') at line 21. This violates the principle of separation of concerns as the domain model should not be tied to a specific AI model version.

Action:

  • Remove the hardcoded default in SemanticKnowledgeCache.cs.
  • Ensure the ModelId is passed from the KnowledgeService during cache creation.
  • Store the default model ID in AiSettings (Infrastructure/Configuration) or as a domain constant in a more appropriate place.
**Full Detail:** The `SemanticKnowledgeCache` entity has a hardcoded default value for `ModelId` ('gemini-1.5-flash') at line 21. This violates the principle of separation of concerns as the domain model should not be tied to a specific AI model version. **Action:** - Remove the hardcoded default in `SemanticKnowledgeCache.cs`. - Ensure the `ModelId` is passed from the `KnowledgeService` during cache creation. - Store the default model ID in `AiSettings` (Infrastructure/Configuration) or as a domain constant in a more appropriate place.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
mjasin (Marek Jaisński)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mjasin/Nexus.Reader#9
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?