mjasin/Nexus.Reader
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

[MN-06] Mapster: Global Configuration Check #5

New Issue
Open
opened 2026-05-05 12:15:03 +00:00 by mjasin · 0 comments
mjasin commented 2026-05-05 12:15:03 +00:00
Owner
Copy Link
Copy Source

Full Detail: MappingConfig.cs (line 12) accesses TypeAdapterConfig.GlobalSettings. While currently safe, if the project scales and more assemblies add mappings via .Scan(), we risk multiple redundant scans which degrade startup performance.

Action:

  • Ensure that any .Scan() or global configuration is wrapped in a check to prevent multiple executions.
  • Consider moving away from GlobalSettings in favor of a specific TypeAdapterConfig instance passed via DI.
**Full Detail:** `MappingConfig.cs` (line 12) accesses `TypeAdapterConfig.GlobalSettings`. While currently safe, if the project scales and more assemblies add mappings via `.Scan()`, we risk multiple redundant scans which degrade startup performance. **Action:** - Ensure that any `.Scan()` or global configuration is wrapped in a check to prevent multiple executions. - Consider moving away from `GlobalSettings` in favor of a specific `TypeAdapterConfig` instance passed via DI.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
mjasin (Marek Jaisński)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mjasin/Nexus.Reader#5
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?