 Antigravity
|
f7dc3b3137
|
fix: resolve all 10 review items from PR #76 (#77)
## Summary
Resolves all 10 review recommendations from the review on PR #76.
## Review Items Addressed
| # | Item | Status |
|---|------|--------|
| 1 | Unit tests for query handler | ✅ Already done (30 tests) |
| 2 | Log exceptions in handler | ✅ `ILogger<GetContextualRecommendationsQueryHandler>` added |
| 3 | Guard empty embedding text | ✅ Early return + empty vector guard in `VectorSearchStore` |
| 4 | Refine collection creation error handling | ✅ Logs creation events and non-fatal errors |
| 5 | Replace `Console.WriteLine` with `ILogger` | ✅ Fixed in 7 components/pages |
| 6 | Abstract HTTP calls behind a service | ✅ `IRecommendationService` + `RecommendationService` |
| 7 | Verify CSS uses design tokens | ✅ `ContextualRecommendationsWidget.razor.css` uses `var(--nexus-*)` |
| 8 | Add loading spinner | ✅ Animated spinner in `ContextualRecommendationsWidget` |
| 9 | Document XML comments | ✅ `<summary>` docs on handler, interface, service |
| 10 | Benchmark vector search latency | ✅ `Stopwatch` around embedding and Qdrant search |
## New Files
- `IRecommendationService.cs` — Application-layer abstraction
- `RecommendationService.cs` — WASM HTTP implementation (AOT-safe)
- `ContextualRecommendationsWidget.razor` — Dashboard UI widget with spinner
- `ContextualRecommendationsWidget.razor.css` — Design-token CSS
## Build
✅ `dotnet build NexusReader.slnx --no-restore` — 0 errors, 5 pre-existing warnings
Closes review: #76 (comment)
---------
Co-authored-by: Marek Jasiński <jasins.marek@gmail.com>
Reviewed-on: #77
Co-authored-by: Antigravity <antigravity@google.com>
Co-committed-by: Antigravity <antigravity@google.com>
|
2026-06-06 13:38:34 +00:00 |
|
mjasin