fix(ui/security): Enforce idempotent AI fetching, secure auth handler, and memory leak guards (#45)
This PR provides critical stabilization, memory leak resolution, and security enhancements for the NexusReader application, specifically focusing on Blazor InteractiveAuto lifecycle safety, thread-safe automated authentication token refresh, and deduplication of active AI service queries. ### Key Enhancements #### 1. Security & Lifecycle Stabilization (`AuthenticationHeaderHandler.cs` & `Library.razor`) * **Secure Token Propagation (CWE-200)**: Modified the outbound delegating handler to only append JWT Bearer headers to trusted base origin requests matching the application's configured `NavigationManager.BaseUri`, preventing potential token leakage to external services. * **Captive Dependency & Memory Leak Fix (CWE-400)**: Avoided capturing scoped dependencies in a singleton handler by wrapping the resolution of `IIdentityService` inside a dedicated, disposable `IServiceProvider` scope (`_serviceProvider.CreateScope()`). * **Thread-Safe Automated Refresh**: Embedded a `SemaphoreSlim` lock around the automated `RefreshTokenAsync` renewal sequence to handle concurrent API requests gracefully without triggering duplicate token refresh attempts. * **Pre-rendering Safety**: Deferred the secure book loading query in `Library.razor` from `OnInitializedAsync` to client-side `OnAfterRenderAsync(firstRender: true)` to avoid inevitable `401 Unauthorized` responses and logs during the server pre-rendering phase. #### 2. Robust AI Request Deduplication (`KnowledgeService.cs`) * **State Recovery Guards**: Enhanced the thread-safe `Lazy<Task<Result<KnowledgePacket>>>` deduplication map by adding thorough failure handling blocks. Active requests are guaranteed to be cleaned up (`TryRemove`) inside `finally` and failed results pathways, ensuring future retries can run immediately if an initial request encounters an error. #### 3. Idempotent AI UI Fetching & JSRuntime Guards * **Interactive Guards**: Added an `_isInteractive` check to `GroundednessBadge.razor` and `AiAssistantBubble.razor` components, deferring WebAssembly API executions and DOM updates to client-side `OnAfterRenderAsync`. * **State Synchronization**: Integrated a synchronous `OnParametersSet` to properly reset groundedness badges when content changes. * **Flicker Elimination**: Moved JSRuntime local-storage checks in `Home.razor` (for focus mode preferences) to `OnAfterRenderAsync(firstRender: true)`, resolving startup JSInterop exceptions and eliminating layout shifts. ### Verification Performed * Mandatory build gate verified: `Kompilacja powiodła się.` with zero compile errors (`dotnet build NexusReader.slnx --no-restore`). * Validated dependency resolution patterns and async safety (no `async void`). --------- Co-authored-by: Marek Jasiński <jasins.marek@gmail.com> Reviewed-on: #45 Reviewed-by: Marek Jaisński <jasins.marek@gmail.com> Co-authored-by: Antigravity <antigravity@google.com> Co-committed-by: Antigravity <antigravity@google.com>
This commit was merged in pull request #45.
This commit is contained in:
@@ -1,31 +1,141 @@
|
||||
using System.Net.Http.Headers;
|
||||
using System.Threading;
|
||||
using Microsoft.AspNetCore.Components;
|
||||
using Microsoft.AspNetCore.Components.WebAssembly.Http;
|
||||
using Microsoft.Extensions.DependencyInjection;
|
||||
using NexusReader.Application.Abstractions.Services;
|
||||
|
||||
namespace NexusReader.Web.Client.Handlers;
|
||||
|
||||
/// <summary>
|
||||
/// A secure HTTP message delegating handler that automatically appends JWT tokens
|
||||
/// to trusted origin requests and transparently refreshes expired tokens in a thread-safe manner.
|
||||
/// </summary>
|
||||
public class AuthenticationHeaderHandler : DelegatingHandler
|
||||
{
|
||||
private readonly INativeStorageService _storageService;
|
||||
private readonly IServiceProvider _serviceProvider;
|
||||
private const string TokenKey = "nexus_auth_token";
|
||||
private static readonly SemaphoreSlim _refreshSemaphore = new(1, 1);
|
||||
|
||||
public AuthenticationHeaderHandler(INativeStorageService storageService)
|
||||
public AuthenticationHeaderHandler(INativeStorageService storageService, IServiceProvider serviceProvider)
|
||||
{
|
||||
_storageService = storageService;
|
||||
_serviceProvider = serviceProvider;
|
||||
}
|
||||
|
||||
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
|
||||
{
|
||||
// Ensure cookies are sent (needed for InteractiveAuto SSR synchronization)
|
||||
// Force browser to forward credentials (cookies) for SSR hydration sync
|
||||
request.SetBrowserRequestCredentials(BrowserRequestCredentials.Include);
|
||||
|
||||
var tokenResult = await _storageService.GetSecureString(TokenKey);
|
||||
|
||||
if (tokenResult.IsSuccess && !string.IsNullOrEmpty(tokenResult.Value))
|
||||
var path = request.RequestUri?.AbsolutePath ?? "";
|
||||
bool isAuthEndpoint = path.Contains("identity/login") ||
|
||||
path.Contains("identity/register") ||
|
||||
path.Contains("identity/refresh");
|
||||
|
||||
// SECURITY FIX (CWE-200): Ensure we only append JWT tokens to local or trusted base origin requests
|
||||
var navigationManager = _serviceProvider.GetRequiredService<NavigationManager>();
|
||||
bool isTrustedHost = request.RequestUri != null &&
|
||||
(!request.RequestUri.IsAbsoluteUri ||
|
||||
request.RequestUri.ToString().StartsWith(navigationManager.BaseUri, StringComparison.OrdinalIgnoreCase));
|
||||
|
||||
string? originalToken = null;
|
||||
|
||||
if (!isAuthEndpoint && isTrustedHost)
|
||||
{
|
||||
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", tokenResult.Value);
|
||||
var tokenResult = await _storageService.GetSecureString(TokenKey);
|
||||
if (tokenResult.IsSuccess && !string.IsNullOrEmpty(tokenResult.Value))
|
||||
{
|
||||
originalToken = tokenResult.Value;
|
||||
request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", originalToken);
|
||||
}
|
||||
}
|
||||
|
||||
return await base.SendAsync(request, cancellationToken);
|
||||
var response = await base.SendAsync(request, cancellationToken);
|
||||
|
||||
// Transparent JWT Auto-Refresh on 401 Unauthorized
|
||||
if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized && !isAuthEndpoint)
|
||||
{
|
||||
await _refreshSemaphore.WaitAsync(cancellationToken);
|
||||
try
|
||||
{
|
||||
// Re-read token to verify if another concurrent request already refreshed it
|
||||
var tokenResult = await _storageService.GetSecureString(TokenKey);
|
||||
var currentToken = tokenResult.IsSuccess ? tokenResult.Value : null;
|
||||
|
||||
bool refreshed = false;
|
||||
|
||||
if (!string.IsNullOrEmpty(currentToken) && currentToken != originalToken)
|
||||
{
|
||||
refreshed = true;
|
||||
}
|
||||
else
|
||||
{
|
||||
// SECURITY FIX (CWE-400): Resolve scoped services within an explicit using scope to prevent memory leaks
|
||||
using var scope = _serviceProvider.CreateScope();
|
||||
var identityService = scope.ServiceProvider.GetRequiredService<IIdentityService>();
|
||||
var refreshResult = await identityService.RefreshTokenAsync();
|
||||
if (refreshResult.IsSuccess)
|
||||
{
|
||||
var newTokenResult = await _storageService.GetSecureString(TokenKey);
|
||||
currentToken = newTokenResult.IsSuccess ? newTokenResult.Value : null;
|
||||
refreshed = !string.IsNullOrEmpty(currentToken);
|
||||
}
|
||||
else
|
||||
{
|
||||
await identityService.LogoutAsync();
|
||||
}
|
||||
}
|
||||
|
||||
if (refreshed && !string.IsNullOrEmpty(currentToken))
|
||||
{
|
||||
var newRequest = await CloneHttpRequestMessageAsync(request);
|
||||
newRequest.Headers.Authorization = new AuthenticationHeaderValue("Bearer", currentToken);
|
||||
return await base.SendAsync(newRequest, cancellationToken);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
// Write standard security audit safe debug log
|
||||
Console.WriteLine($"[AuthHeaderHandler] Automated token renewal failed: {ex.Message}");
|
||||
}
|
||||
finally
|
||||
{
|
||||
_refreshSemaphore.Release();
|
||||
}
|
||||
}
|
||||
|
||||
return response;
|
||||
}
|
||||
|
||||
private async Task<HttpRequestMessage> CloneHttpRequestMessageAsync(HttpRequestMessage req)
|
||||
{
|
||||
var clone = new HttpRequestMessage(req.Method, req.RequestUri)
|
||||
{
|
||||
Version = req.Version
|
||||
};
|
||||
|
||||
if (req.Content != null)
|
||||
{
|
||||
var ms = new System.IO.MemoryStream();
|
||||
await req.Content.CopyToAsync(ms);
|
||||
ms.Position = 0;
|
||||
clone.Content = new StreamContent(ms);
|
||||
|
||||
foreach (var h in req.Content.Headers)
|
||||
{
|
||||
clone.Content.Headers.TryAddWithoutValidation(h.Key, h.Value);
|
||||
}
|
||||
}
|
||||
|
||||
foreach (var h in req.Headers)
|
||||
{
|
||||
clone.Headers.TryAddWithoutValidation(h.Key, h.Value);
|
||||
}
|
||||
|
||||
clone.SetBrowserRequestCredentials(BrowserRequestCredentials.Include);
|
||||
|
||||
return clone;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user